Make CustomizableOperation Send and Sync
#2951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Velfi
approved these changes
Aug 25, 2023
jdisanti
reviewed
Aug 25, 2023
...amazon/smithy/rust/codegen/client/smithy/generators/client/CustomizableOperationGenerator.kt
Outdated
Show resolved
Hide resolved
This commit addresses #2951 (comment)
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
approved these changes
Aug 25, 2023
|
hmm, cargo semver-checks should have caught this 🤔 |
rcoh
reviewed
Aug 28, 2023
| pub(crate) interceptors: Vec<#{SharedInterceptor}>, | ||
| pub(crate) runtime_plugins: Vec<#{SharedRuntimePlugin}>, | ||
| pub struct CustomizableOperation<T, E, B> { | ||
| customizable_send: B, |
There was a problem hiding this comment.
interesting—I would have thought that just adding the trait bounds would be enough : Send + Sync, I mean, and we could have stayed with Box<dyn ...> doesn't really matter either way though, I guess.
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes #2944
Description
CustomizableOperationin the last two releases (release-2023-08-01 and release-2023-08-22) broke backward-compatibility with respect to its auto traits. Specifically, it ceased to beSendandSyncbecause the struct contained a boxed trait object. This PR fix that issue, makingCustomizableOperationSendandSyncagain.Testing
CustomizableOperationisSendandSync.Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.